Skip to content

Support for themes and new design system. #4543

Merged
frjo merged 251 commits into
mainfrom
themes
Jul 9, 2025
Merged

Support for themes and new design system. #4543
frjo merged 251 commits into
mainfrom
themes

Conversation

@theskumar

@theskumar theskumar commented May 15, 2025

Copy link
Copy Markdown
Member

Implementing theme support with https://daisyui.com

Test Steps

  • Test lock and feel of everything

Comment thread hypha/static_src/javascript/esm/choices.js-10-2-0.js Outdated
@frjo

This comment was marked as resolved.

frjo
frjo previously requested changes Jun 3, 2025
Comment thread Makefile Outdated
@frjo frjo added Type: Feature This is something new (not an enhancement of an existing thing). Type: Minor Minor change, used in release drafter labels Jun 4, 2025
@theskumar

Copy link
Copy Markdown
Member Author

Thank you for the comments, all very good feedback.

12/ This is minor thing but current implementation doesn't allow for updating the circle color in a simple way. The whole line and the circle change color if I pick a different type for a particular stage. I would suggest leave it like this for now.

5/ The borders subtle b/c of the theme selected the default light theme, the corperate theme has more high lighted border, i noticed this well, will update it in the custom hypha theme.

I'll look into other points and make changes as suggested.

@frjo

frjo commented Jul 7, 2025

Copy link
Copy Markdown
Member

@theskumar A rebase would be good.

@wes-otf

wes-otf commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

It looks like the Continue editing button on application preview stopped working and help text for file uploads is a bit weird:
Screenshot 2025-07-07 at 13 14 03

I like the system theme detection that's happening now though! super cool

@theskumar

theskumar commented Jul 8, 2025

Copy link
Copy Markdown
Member Author

rebased, and fixed the the help text issues. Also, did some minor tweaks to dark theme.

From my perspective, the current version is more or less ready to ship, functionally. I'll now focus on more cleanup, while we wrap up the reviews.

@wes-otf can't reproduce the Continue Editing bug, it's simply a link and weird it's not working.

@frjo

frjo commented Jul 8, 2025

Copy link
Copy Markdown
Member

The new theme switcher works and looks great.

I'm unsure about switching place between language and theme switcher. To me language feels more important.

@theskumar

Copy link
Copy Markdown
Member Author

The new theme switcher works and looks great.

glad you liked it.

I'm unsure about switching place between language and theme switcher. To me language feels more important.

I've used the UX pattern from Django's official documentation website. I think it's debatable, as I've seen language switchers which, in most cases, are either server-side configured or detected automatically by the browser placed at the bottom. Happy to swap back the position. I don't have a very strong preference.

Screenshot 2025-07-08 at 1  37 26@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Feature This is something new (not an enhancement of an existing thing). Type: Minor Minor change, used in release drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants