Conversation
4ca189e to
f567f59
Compare
c9317fa to
46fc872
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
Thank you for the comments, all very good feedback. 12/ This is minor thing but current implementation doesn't allow for updating the 5/ The borders subtle b/c of the theme selected the default I'll look into other points and make changes as suggested. |
|
@theskumar A rebase would be good. |
|
rebased, and fixed the the help text issues. Also, did some minor tweaks to dark theme. From my perspective, the current version is more or less ready to ship, functionally. I'll now focus on more cleanup, while we wrap up the reviews. @wes-otf can't reproduce the |
|
The new theme switcher works and looks great. I'm unsure about switching place between language and theme switcher. To me language feels more important. |
glad you liked it.
I've used the UX pattern from Django's official documentation website. I think it's debatable, as I've seen language switchers which, in most cases, are either server-side configured or detected automatically by the browser placed at the bottom. Happy to swap back the position. I don't have a very strong preference. |


Implementing theme support with https://daisyui.com
Test Steps